Skip to content

BREAKING CHANGE: remove deprecated QuanityFactory.from_backend() #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
romanc merged 1 commit into from
Jan 16, 2026
Merged

BREAKING CHANGE: remove deprecated QuanityFactory.from_backend() #356

romanc merged 1 commit into from
Jan 16, 2026

Conversation

@romanc
Copy link
Collaborator

@romanc romanc commented Jan 8, 2026 •
edited
Loading

Description

QuanityFactory.from_backend(...) was deprecated with NDSL release 2025.11.00. The function is superseded by the new constructor. See #228 for context.

Blocked by NOAA-GFDL/pace#169, NOAA-GFDL/PyFV3#108, NOAA-GFDL/PySHiELD#79, NOAA-GFDL/pace#173

How has this been tested?

All good as long as CI is still green.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation (e.g. add new modules to docs/docstrings/): N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included: N/A

@romanc
BREAKING CHANGE: remove deprecated QuanityFactory.from_backend()
155c2d7 
`QuanityFactory.from_backend(...)` was deprecated with NDSL release
`2025.11.00`. The function is superseded by the new constructor. See
NOAA-GFDL#228 for context.
@romanc romanc changed the title BREAKING CHANGE: remove deprecated QuanityFactory.from_backend() BREAKING CHANGE: remove deprecated QuanityFactory.from_backend() Jan 8, 2026
This was referenced Jan 13, 2026
Merged
Merged
Merged
@romanc romanc marked this pull request as ready for review January 16, 2026 14:34
@romanc romanc enabled auto-merge January 16, 2026 14:35
FlorianDeconinck
FlorianDeconinck approved these changes Jan 16, 2026
View reviewed changes
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@romanc romanc added this pull request to the merge queue Jan 16, 2026
Merged via the queue into NOAA-GFDL:develop with commit f5605ca Jan 16, 2026
6 of 8 checks passed
@romanc romanc deleted the romanc/remove-quantity-facotry-from-backend branch January 16, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FlorianDeconinck FlorianDeconinck FlorianDeconinck approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@romanc @FlorianDeconinck